Add Column.is_number/is_float (#1969) #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out snowflake column type added column type test integration tests
beckjake
force-pushed
the
feature/is-number
branch
from
b70989a
to
54b64f8
Compare
drewbanin
reviewed
Jan 24, 2020
| def is_numeric(self) -> bool: | ||
| return self.dtype.lower() in ['numeric', 'number'] | ||
| return self.dtype.lower() in ['numeric', 'decimal'] |
There was a problem hiding this comment.
This change is the only thing in this PR that I'm not sure about -- do you know why number was in here before? I tried looking through the blame but couldn't find the origin.... AFAICT number is not a valid type on pg/redshift/snowflake/bq.....?
There was a problem hiding this comment.
It's only valid on snowflake, and previously this method applied for Snowflake as well as postgres/redshift. That's why I removed it when I split snowflake out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1969
A fun question to think about: on snowflake, is nothing an integer, or is everything? Snowflake doesn't technically have non-
NUMBERinteger types: https://docs.snowflake.net/manuals/sql-reference/data-types-numeric.html#int-integer-bigint-smallint-tinyint-byteint - On the database end,information_schema.columnsreports all these as being DECIMAL(38, 0). I've gone with: everything on snowflake isnumeric,float, ortextand none of it isinteger.