Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make err msg for malformed packages.yml more clear #2077

Closed
wants to merge 0 commits into from
Closed

make err msg for malformed packages.yml more clear #2077

wants to merge 0 commits into from

Conversation

sonac
Copy link
Contributor

@sonac sonac commented Jan 29, 2020

As it's described in #2017, an error message in case of malformed packages.yml could be misleading, defaulting to the case of the local package when it's not matching any of the three documented specs.

@cla-bot
Copy link

cla-bot bot commented Jan 29, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @sonac

@drewbanin
Copy link
Contributor

Thanks @sonac - this PR looks great! @cla-bot check

Kicking off the tests now too

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2020
@cla-bot
Copy link

cla-bot bot commented Jan 29, 2020

The cla-bot has been summoned, and re-checked this pull request!

@drewbanin drewbanin changed the base branch from dev/0.15.2 to dev/barbara-gittings January 29, 2020 22:47
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the base branch for this PR to dev/barbara-gittings -- do you mind rebasing as necessary? Once that's done, this should be good to merge :)

.gitignore Outdated
@@ -83,3 +83,6 @@ target/

# pycharm
.idea/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these lines from the .gitignore please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it won't hurt for people using vscode, but alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants