Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty SQL in persist docs (#2439) #2440

Merged
merged 1 commit into from
May 13, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2439

Description

When persist_docs is set and there are no columns described, don't add comments!

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Also remove unused (and confusing/misleading) test data
@cla-bot cla-bot bot added the cla:yes label May 12, 2020
@beckjake beckjake requested a review from drewbanin May 12, 2020 21:02
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Ship it

@beckjake beckjake merged commit 457cbbd into dev/marian-anderson May 13, 2020
@beckjake beckjake deleted the fix/empty-persist-docs branch May 13, 2020 14:39
@beckjake beckjake restored the fix/empty-persist-docs branch May 13, 2020 14:43
@beckjake beckjake mentioned this pull request May 13, 2020
4 tasks
beckjake added a commit that referenced this pull request May 13, 2020
@beckjake beckjake deleted the fix/empty-persist-docs branch May 13, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.17.0: Cannot execute an empty query
2 participants