-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for impersonating a service account with BigQuery #2677
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Preston Marshall.
|
I added a test but it doesn't seem very useful. Not really sure the existing tests are setup in a way to easily test this without major mocking, I don't see any other authentication tests. Let me know what else is needed. |
@bbhoss You're right, in general we don't have as much testing for non-default authentication methods (Snowflake SSO being the big exception). In this specific case, since CircleCI runs our integration tests against BigQuery using a service account (and it doesn't sound like they support oauth), I don't know if we have a better option. I'm still going to test this locally by oauth'ing into our sandboxed BigQuery account and impersonating Circle's service account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for writing up those docs.
We don't have rigorous tests for this, but the code change is quite self-contained. As long as it worked for you in your project and for me in a dummy project, I feel good about merging this in (tomorrow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
resolves #2672
Description
See #2672. Opening up this draft as I hope to get some early feedback. Tests and docs are the main TODOs, I still need to figure out how the testing works.
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.