Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impersonate service account docs #323

Merged
merged 5 commits into from
Aug 4, 2020
Merged

Conversation

bbhoss
Copy link
Contributor

@bbhoss bbhoss commented Aug 3, 2020

Description & motivation

Associated with dbt-labs/dbt-core#2672 and dbt-labs/dbt-core#2672

To-do before merge

Merge dbt-labs/dbt-core#2677

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes
  • No (if you're not sure, it's probably "No")

If yes, please change the base branch of this PR to next

@bbhoss bbhoss requested a review from clrcrl as a code owner August 3, 2020 16:50
@bbhoss bbhoss changed the title Patch 1 Add impersonate service account docs Aug 3, 2020
@clrcrl
Copy link
Contributor

clrcrl commented Aug 3, 2020

@jtcohen6 — assigning to you as product manager :)

@clrcrl clrcrl removed their request for review August 3, 2020 17:45
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing such detailed docs!

Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for those updates!

@jtcohen6 jtcohen6 merged commit ac23013 into dbt-labs:next Aug 4, 2020
@bbhoss bbhoss deleted the patch-1 branch August 4, 2020 18:56
@jtcohen6 jtcohen6 mentioned this pull request Sep 3, 2020
nghi-ly pushed a commit that referenced this pull request Feb 13, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants