Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.18.0 #367

Merged
merged 60 commits into from
Sep 3, 2020
Merged

Release 0.18.0 #367

merged 60 commits into from
Sep 3, 2020

Conversation

rsenseman and others added 30 commits July 14, 2020 16:58
Documentation follows from dbt-labs/dbt-core#2622
Update v0.18.0 migration guide, PR template for `next`
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Add impersonate service account docs
Co-authored-by: Jacob Beck <beckjake@users.noreply.github.com>
Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the header bar still has the pre-release banner. Other than that, LGTM!

@@ -4,4 +4,5 @@

[context.next.environment]
PRERELEASE = "true"
ALGOLIA_INDEX_NAME = "dbt-next"
ALGOLIA_API_KEY = "044414e92a8b8137a33fd276d4533895"
ALGOLIA_INDEX_NAME = "dbt_next"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove this?

Copy link
Collaborator

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and also a request to remove the "prerelease" banner for prod deployment

Co-authored-by: Drew Banin <drew@fishtownanalytics.com>
@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Sep 3, 2020

@clrcrl @drewbanin Thanks for the review! No need to make any changes re: the Algolia values or the prerelease banner. Those are conditional in Netlify based on whether it is building the next branch, so they won't affect docs.getdbt.com.

@jtcohen6 jtcohen6 merged commit d2b5c17 into current Sep 3, 2020
nghi-ly pushed a commit that referenced this pull request Feb 13, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants