Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run.md to document new dbt run options --use-colors and --no-use-colors #286

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

rsenseman
Copy link
Contributor

@rsenseman rsenseman commented Jul 14, 2020

Summary

Add documentation for new dbt run command line flags --use-colors and --no-use-colors. Documentation follows from dbt contribution here

Documentation follows from dbt-labs/dbt-core#2622
@rsenseman rsenseman requested a review from clrcrl as a code owner July 14, 2020 23:59
@rsenseman rsenseman changed the title Update run.md Update run.md to document new dbt run options --use-colors and --no-use-colors Jul 15, 2020
@clrcrl clrcrl requested a review from jtcohen6 July 29, 2020 21:30
@clrcrl clrcrl changed the base branch from master to next July 29, 2020 21:31
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you:

  • Fix the merge conflict in run.md
  • Add run/enable-or-disable-colorized-logs to the list of "New and changed documentation" in the v0.18.0 migration guide

@@ -102,3 +102,12 @@ Encountered an error:
FailFast Error in model model_1 (models/model_1.sql)
Failing early due to test failure or runtime error
```

## Enable or Disable Colorized Logs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog note here:

<Changelog>New in v0.18.0</Changelog>

@rsenseman
Copy link
Contributor Author

@jtcohen6 Done and done

@jtcohen6 jtcohen6 merged commit 06492cd into dbt-labs:next Aug 19, 2020
@rsenseman rsenseman deleted the patch-1 branch August 19, 2020 17:44
@jtcohen6 jtcohen6 mentioned this pull request Sep 3, 2020
nghi-ly pushed a commit that referenced this pull request Feb 13, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants