Fix: require keyring on snowflake #2789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2779
Description
dbt-snowflake
:snowflake-connector-python[secure-local-storage]
, which is really justkeyring
Alternatives
We could put
snowflake-connector-python[secure-local-storage]
underextras_require
instead ofinstall_requires
, since it's only really needed for external-browser auth. I opted for the more aggressive approach since:keyring
insnowflake-connector-python
is quite permissiveI don't really know what I'm doing, though, when it comes to python deps!
Checklist
I have run this code in development and it appears to resolve the stated issueThis PR includes tests, or tests are not required/relevant for this PRCHANGELOG.md
and added information about my change to the "dbt next" section.