Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various quality of life improvements #40

Merged
merged 23 commits into from
Oct 2, 2024
Merged

Conversation

fiskenslakt
Copy link
Owner

@fiskenslakt fiskenslakt commented Sep 18, 2024

Added:

  • New commands
    • /rename (update name column of a user)
    • /endow (makes user a point giver)
    • /disendow (removes ability to give points from user)
  • point_giver column
    • determines user's ability to give points
    • False by default
  • Can set point_giver when registering new user
  • Helper function to validate names

Changed:

  • Timestamps will use special discord timestamp syntax going forward so they are in the timezone of the discord user viewing it
  • pycord version bump
  • special "everyone" syntax requires both being a discord user and being a point giver to receive points
  • /user command has been updated considerably
    • Shows all users instead of just showing ones that are active
    • Paginated, sorted, and in a single column
    • Shows more data about each user
  • Point syntax no longer supports for <recipient>
  • Moved various points related settings to settings.py

@fiskenslakt fiskenslakt added the enhancement New feature or request label Sep 18, 2024
@fiskenslakt fiskenslakt linked an issue Sep 19, 2024 that may be closed by this pull request
@fiskenslakt fiskenslakt marked this pull request as ready for review September 19, 2024 02:05
@rbrammen
Copy link

Approved for PROD production push

pzsd_bot/cogs/points.py Outdated Show resolved Hide resolved
@fiskenslakt fiskenslakt force-pushed the fundamental-improvements branch from 7846543 to 1d08aa3 Compare September 20, 2024 19:37
@@ -41,5 +42,48 @@ class _DB(EnvConfig):

DB_CONNECTION_STR = f"postgresql+asyncpg://{DB.pguser}:{DB.pgpassword}@{DB.pghost}:{DB.pgport}/{DB.pgdatabase}"


class _PointsSettings(EnvConfig):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Badly named

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Parsing" maybe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParsingSettings

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParsingConstants

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't love it either, but I couldn't name it _Points like I originally wanted to without renaming the Points class in points.py. And I can't think of an alternate name. Suggestions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParsingConstants

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of these names lol. I'm not opposed to renaming in the future, but until we come up with a better one, I'm keeping it the same for now.

Copy link
Collaborator

@sethdandridge sethdandridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmpc

Copy link
Collaborator

@sethdandridge sethdandridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change name of PointsSettings. This is a critical blocker

@fiskenslakt
Copy link
Owner Author

please change name of PointsSettings. This is a critical blocker

OVERRULED

@fiskenslakt fiskenslakt merged commit 33ab3ce into main Oct 2, 2024
@fiskenslakt fiskenslakt deleted the fundamental-improvements branch October 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /rename command
4 participants