-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various quality of life improvements #40
Conversation
- Show all users not just active ones - Show more data about each user - Paginate and sort results
Also add 'me' to reserved names
Approved for PROD production push |
7846543
to
1d08aa3
Compare
pzsd_bot/settings.py
Outdated
@@ -41,5 +42,48 @@ class _DB(EnvConfig): | |||
|
|||
DB_CONNECTION_STR = f"postgresql+asyncpg://{DB.pguser}:{DB.pgpassword}@{DB.pghost}:{DB.pgport}/{DB.pgdatabase}" | |||
|
|||
|
|||
class _PointsSettings(EnvConfig): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Badly named
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Parsing" maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ParsingSettings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ParsingConstants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't love it either, but I couldn't name it _Points
like I originally wanted to without renaming the Points
class in points.py. And I can't think of an alternate name. Suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ParsingConstants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of these names lol. I'm not opposed to renaming in the future, but until we come up with a better one, I'm keeping it the same for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtmpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change name of PointsSettings. This is a critical blocker
OVERRULED |
Added:
name
column of a user)point_giver
columnFalse
by defaultpoint_giver
when registering new userChanged:
for <recipient>