Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor points cog #43

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Refactor points cog #43

merged 2 commits into from
Jan 10, 2025

Conversation

fiskenslakt
Copy link
Owner

@fiskenslakt fiskenslakt commented Oct 24, 2024

Simply splits various points logic into separate more focused modules. As of writing, there is no new code nor any code being removed.

The biggest change is that I moved the page_buttons property to settings.py because I now need it in multiple modules.

I've tested all points commands as well as tested giving points, and everything seems to still work as before.

@fiskenslakt fiskenslakt linked an issue Oct 24, 2024 that may be closed by this pull request
@fiskenslakt fiskenslakt marked this pull request as ready for review October 25, 2024 05:00
Copy link
Collaborator

@sethdandridge sethdandridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmpc

@fiskenslakt fiskenslakt merged commit 2782538 into main Jan 10, 2025
@fiskenslakt fiskenslakt deleted the refactor-points-cog branch January 10, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor points cog
2 participants