Extract environment proxy #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced the map in the proxy struct with a cache - Added the building of proxy image to all scripts
…kflow engine Added an option to the bundle to include or exclude the proxy
erwinvaneyk
force-pushed
the
standalone-proxy
branch
from
684aa89 to
98857cc
Compare
erwinvaneyk
force-pushed
the
standalone-proxy
branch
from
98857cc to
b6a248d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the workflow engine needs to be deployed through Fission as a regular Fission environment. This means that Fission controls the deployment, Kubernetes resources and application lifecycle. Although this sounded useful initially, over time we found that this approach is not ideal for quick development, testing and customizing the workflow deployment.
This PR extracts the fission environment proxy from workflow engine, to allow the user to fully control the workflow engine deployment. This makes it easier to develop and test the workflow engine, using common development practices for Kubernetes. It removes any interference of the Fission executor on the lifecycle. Finally, it is clearer to the user where the workflows end up in.
Finally, next to this, this PR adds...