Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hebrew.monthcalendar returns a 6-day week #58

Open
clsn opened this issue May 22, 2023 · 1 comment
Open

hebrew.monthcalendar returns a 6-day week #58

clsn opened this issue May 22, 2023 · 1 comment
Labels

Comments

@clsn
Copy link

clsn commented May 22, 2023

from convertdate import hebrew
hebrew.monthcalendar(5782, 10)
[[1, 2, 3, 4, 5, 6, 7], [8, 9, 10, 11, 12, 13, 14], [15, 16, 17, 18, 19, 20, 21], [22, 23, 24, 25, 26, 27, 28], [29, None, None, None, None, None]]

Note that the last element, which is supposed to be a week, has only six elements instead of seven, like it does in other cases.
Have not yet tracked down the source of the problem.

@clsn
Copy link
Author

clsn commented May 22, 2023

utils.monthcalendarhelper(start_weekday, month_length) is buggy when start_weekday is 6, though it doesn't seem to be a problem when the month_length is less than 29.

clsn pushed a commit to clsn/convertdate that referenced this issue May 22, 2023
We don't really have to compute the ending day or the rpad anyway.
@fitnr fitnr added the bug label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants