Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust README.md #8

Merged
merged 2 commits into from
May 9, 2023
Merged

feat: adjust README.md #8

merged 2 commits into from
May 9, 2023

Conversation

dancesWithCycles
Copy link

Hi folks,
Thank you so much for providing and maintaining this repository. Please feel free to study, adjust, share and use the pull request. I adjusted the README.md in a way the Makefile init target is working for me.

Cheers!

@fitnr
Copy link
Owner

fitnr commented May 5, 2023

I don't want to explicitly advise setting the PGPASSWORD variable, which could be a security hazard. It would probably be more succinct and clear to note that the user should set any necessary PG* environment variables.

@dancesWithCycles
Copy link
Author

t would probably be more succinct and clear to note that the user should set any necessary PG* environment variables.

@fitnr Agree! I updated the pull request. Cheers!

@fitnr fitnr merged commit e42ac3f into fitnr:master May 9, 2023
@dancesWithCycles dancesWithCycles deleted the readme branch May 10, 2023 04:26
dancesWithCycles added a commit to dancesWithCycles/gtfs2sql that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants