Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the district & village names to the original case #51

Merged
merged 5 commits into from
Sep 16, 2023
Merged

Rewrite the district & village names to the original case #51

merged 5 commits into from
Sep 16, 2023

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Sep 16, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Data change

What is the current behavior?

Issue Number: #46

What is the new behavior?

  • Rewrite district name to original case
  • Rewrite village name to original case
  • Allow ", *, and ’ characters in village name
  • Update the related tests

Other information

REF-2022-2

@fityannugroho fityannugroho added the documentation Improvements or additions to documentation label Sep 16, 2023
@fityannugroho fityannugroho self-assigned this Sep 16, 2023
@fityannugroho fityannugroho linked an issue Sep 16, 2023 that may be closed by this pull request
Rewrite the district and village name into the original case #46
Closed
3 tasks
@fityannugroho fityannugroho merged commit 0e8df1b into main Sep 16, 2023
@fityannugroho fityannugroho deleted the issue-46 branch September 16, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fityannugroho fityannugroho

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite the district and village name into the original case
1 participant
@fityannugroho