Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull origin #6

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Pull origin #6

merged 4 commits into from
Jun 25, 2019

Conversation

fitzf
Copy link
Owner

@fitzf fitzf commented Jun 25, 2019

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

slievrly and others added 4 commits June 20, 2019 07:01
@slievrly @ralf0131
remove unnecessary null check before instance of (#4321)
81e61cc 
Signed-off-by: jimin.jm <slievrly@163.com>
@zhenxianyimeng @ralf0131
add zookeeper maven dependency so that on change registery can run th…
60c9d9d 
…e demo (#4352)
@htynkn @lovepoem
[Dubbo-4355] Fix dubbo.jar do not contain "serialization-protobuf-jso…
fa619c9 
…n" module issue (#4356) (#4364)

* include protobuf-json jar to dubbo
@HzjNeverStop @zonghaishang
[Dubbo-4299]Fix NPE when PojoUtils realize Null element in collection(#…
7285ce9 
…4299) (#4300)

* fix NPE when PojoUtils realize Null element in collection(#4299)

* add unit tests for bugfix of PojoUtils NPE(#4299)

* revert import (#4299)
@fitzf fitzf merged commit 89fa7d2 into fitzf:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fitzf @slievrly @zhenxianyimeng @htynkn @HzjNeverStop