Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update criterion to 0.5 #213

Closed
wants to merge 1 commit into from

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

Copy link
Owner

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Does this version of criterion still produce HTML reports by default, or do we need to enable a feature now?

@waywardmonkeys
Copy link
Contributor Author

I will get back to you about that (in 18-36 hours as I'm about to disappear for 16 hours or so). There's also the issue of the failed MSRV build. Arguably, the MSRV build shouldn't compile everything, but only the core library?

@waywardmonkeys
Copy link
Contributor Author

@fitzgen Okay, I added html_reports to the features for it.

That leaves MSRV. anstyle requires 1.64, you want 1.63 (but the rust-version in the Cargo.toml is still set to 1.60). Would you want to bump to 1.64 or 1.66? Or not compile tests for MSRV?

@fitzgen
Copy link
Owner

fitzgen commented Aug 23, 2023

The tests should run for the MSRV, but benchmarks don't need to. I think cargo compiles all dev deps for tests though.

I think it is fine to bump the MSRV. Would you mind updating the rust-version in Cargo.toml, CI, and the README's documentation as well?

Thanks @waywardmonkeys!

@waywardmonkeys
Copy link
Contributor Author

Now anstyle wants 1. 70 or later ... I'm not going to chase this as it is somewhat ridiculous.

@fitzgen
Copy link
Owner

fitzgen commented Apr 14, 2024

Closing old pull requests.

@fitzgen fitzgen closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants