Improve performance of String::from_str_in
#231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated performance of
String::from_str_in
. Turns out that even afterString::push_str
is optimized (#229), the compiler does not figure out that bounds checks and various calculations can be elided.So this change makes
from_str_in
about 18% faster for small strings.PR includes a benchmark to demonstrate this.
Built on top of #229. If you're willing to merge, please merge that one first.
Sorry for sudden barrage of issues and PRs!