Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bump::shrink illegal copies #232

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix Bump::shrink illegal copies #232

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c7d1f
Fix `Bump::shrink` illegal copies
overlookmotel Feb 14, 2024
1be6a22
Expand comment about why we round up in the `shrink` check
fitzgen Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,7 +1724,10 @@ impl Bump {
// Only reclaim the excess space (which requires a copy) if it
// is worth it: we are actually going to recover "enough" space
// and we can do a non-overlapping copy.
&& delta >= old_size / 2
// `(old_size + 1) / 2` so division rounds up rather than down,
// so this test fails for e.g. `old_size` = 1, `new_size` = 1
// or `old_size` = 5, `new_size` = 3 (which would overlap).
fitzgen marked this conversation as resolved.
Show resolved Hide resolved
&& delta >= (old_size + 1) / 2
{
let footer = self.current_chunk_footer.get();
let footer = footer.as_ref();
Expand Down