feature/pinterest-keywords-variable-addition

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: #77

This PR will result in the following new package version: v1.4.0

While this isn't technically breaking, it will be included in the next major release. As such we will mark it as breaking.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR includes a new variable pinterest__using_keywords that allows users to disable the keywords reports within Pinterest if they are not needed or are not located within the users source schema.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (pinterest__using_keywords set to both true and false)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

• Variable set to false with all other ad platforms (excluding amazon ads) enabled.

  • The keyword tables are not included
    

• Variable set to true with all other ad platforms (excluding amazon ads) enabled.

  • The keyword tables are included
    

• Variable not defined (default) with all other ad platforms (excluding amazon ads) enabled.

  • The keyword tables are included
    

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• [n/a] DECISIONLOG updates have been updated (if applicable)
• [n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

📚

[fivetran-reneeli]

Changes look good but don't forget to update the version!

[fivetran-joemarkiewicz]

Changes look good but don't forget to update the version!

Thanks for catching @fivetran-reneeli, this is going to be merged into the release/v1.4.0 branch so the version should be bumped when merging into there. If all else looks good would you be able to approve or add any other comments before merging to the release branch. Thanks!

[fivetran-reneeli]

Lgtm!

[fivetran-catfritz]

Standard reminder.