schema_changelog incremental materialization #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
commented
Feb 15, 2022
| @@ -20,7 +50,8 @@ add_connector_info as ( | |||
| connector.destination_id, | |||
| connector.destination_name | |||
|
|
|||
| from schema_changes join connector using(connector_id) | |||
| from schema_changes join | |||
There was a problem hiding this comment.
just changed this as using can be volatile sometimes (mostly just left joins on snowflake but let's be consistent)
fivetran-reneeli
approved these changes
Feb 22, 2022
|
Hi all, Just wanted to provide an update here that this is currently a working and functional branch that properly adds incremental logic to the changelog. Currently the open issue #33 has not been closed and this PR has not been merged because there has not been enough interest into this feature. If you would like this Feature added to a future release of this package, please comment below. Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
no fivetran made PR, for TR
What change(s) does this PR introduce?
materializes the
fivetran_log__schema_changelogmodel incrementally and adds relevant circle ci log dataDoes this PR introduce a breaking change?
everything should run fine if/when this is merged
Is this PR in response to a previously created Issue
How did you test the PR changes?
and locally on BQ
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
☁️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.