Feature/unit testing phase1 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-sheringuyen
changed the base branch from
master
to
releases/v0.4.latest
|
I will..squash before merge 😅 |
fivetran-joemarkiewicz
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
@fivetran-sheringuyen this is great and will really help us unsure that changes to this package have more coverage than just releasing and hoping a potential bug isn't introduced!
I have one small comment, but other than that - this looks great to go! I do want to hold off merging and releasing this until PR #100 is completed.
Comment on lines
+2
to
+11
| version: [">=0.6.0", "<0.7.0"] | ||
| - package: fivetran/zendesk | ||
| version: [">=0.10.0", "<0.11.0"] | ||
| - package: fivetran/hubspot | ||
| version: [">=0.8.0", "<0.9.0"] | ||
| - package: fivetran/jira | ||
| version: [">=0.11.0", "<0.12.0"] | ||
| - package: fivetran/klaviyo | ||
| version: [">=0.5.0", "<0.6.0"] |
There was a problem hiding this comment.
Should we maybe make these ranges larger? I would want to make sure we are testing on the latest versions of them.
There was a problem hiding this comment.
I think there's a couple of different things we could do here.
- Broaden the range as you are suggesting and having the upper bound be < 1.0.0
or - Having
revision: mainfor the git reference. This ensures that it's always the latest version of main, although not necessarily a release. So there is a minor caveat here but for this context, I think it would be ok.
fivetran-jamie
changed the base branch from
releases/v0.4.latest
to
releases/v0.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds a dbt compile test to our Fivetran Utils package
If this PR introduces a new macro, how did you test the new macro?
If this PR introduces a modification to an existing macro, which packages is the macro currently present in and what steps were taken to test compatibility across packages?
Did you update the README to reflect the macro addition/modifications?
Integration testing for internal uses