bugfix/variable-configs (#137)

* bugfix/variable-configs * pr ref in changelog * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
fivetran · Mar 5, 2024 · bf9aec2 · bf9aec2
1 parent b4f961a
commit bf9aec2
Show file tree

Hide file tree

Showing 11 changed files with 26 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,14 @@
+# dbt_hubspot v0.17.0
+[PR #137](https://github.com/fivetran/dbt_hubspot/pull/137) includes the following updates:
+
+## 🚨 Breaking Changes: Variable Bug Fixes 🚨 
+- The following are now dependent on the `hubspot_email_event_sent_enabled` variable being defined as `true`:
+  -`hubspot__contact_lists` email metric fields
+  -`hubspot__contact` email metric fields
+  -`hubspot__email_campaigns` model
+  -`int_hubspot__email_metrics__by_contact_list` model
+> **Note**: This is a breaking change for users who have the `hubspot_email_event_sent_enabled` variable set to `false` as this update will change the above behaviors of the package. For all other users, these changes will not be breaking. 
+
 # dbt_hubspot v0.16.0
 [PR #135](https://github.com/fivetran/dbt_hubspot/pull/135) includes the following updates:
 

diff --git a/README.md b/README.md
@@ -73,7 +73,7 @@ Include the following hubspot package version in your `packages.yml` file:
 ```yaml
 packages:
   - package: fivetran/hubspot
-    version: [">=0.16.0", "<0.17.0"] # we recommend using ranges to capture non-breaking changes automatically
+    version: [">=0.17.0", "<0.18.0"] # we recommend using ranges to capture non-breaking changes automatically
 
 ```
 Do **NOT** include the `hubspot_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well.

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'hubspot'
-version: '0.16.0'
+version: '0.17.0'
 
 config-version: 2
 require-dbt-version: [">=1.3.0", "<2.0.0"]

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/docs/run_results.json b/docs/run_results.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,17 +1,17 @@
 name: 'hubspot_integration_tests'
-version: '0.16.0'
+version: '0.17.0'
 
 profile: 'integration_tests'
 config-version: 2
 vars:
   hubspot_schema: hubspot_integration_tests_11
   hubspot_source:
     hubspot_service_enabled: true
-    # hubspot_sales_enabled: true # enable when generating docs
-    # hubspot_marketing_enabled: true # enable when generating docs
-    # hubspot_contact_merge_audit_enabled: true # enable when generating docs
-    # hubspot_using_all_email_events: true # enable when generating docs
-    # hubspot_merged_deal_enabled: true # enable when generating docs  
+    hubspot_sales_enabled: true # enable when generating docs
+    hubspot_marketing_enabled: true # enable when generating docs
+    hubspot_contact_merge_audit_enabled: true # enable when generating docs
+    hubspot_using_all_email_events: true # enable when generating docs
+    hubspot_merged_deal_enabled: true # enable when generating docs  
     hubspot_company_property_history_identifier: "company_property_history_data"
     hubspot_company_identifier: "company_data"
     hubspot_contact_identifier: "contact_data"

diff --git a/models/marketing/hubspot__contact_lists.sql b/models/marketing/hubspot__contact_lists.sql
@@ -6,7 +6,7 @@ with contact_lists as (
     select *
     from {{ var('contact_list') }}
 
-{% if fivetran_utils.enabled_vars(['hubspot_marketing_enabled', 'hubspot_email_event_enabled','hubspot_contact_enabled']) %}
+{% if fivetran_utils.enabled_vars(['hubspot_marketing_enabled','hubspot_email_event_enabled','hubspot_contact_enabled','hubspot_email_event_sent_enabled']) %}
 
 ), email_metrics as (
 

diff --git a/models/marketing/hubspot__contacts.sql b/models/marketing/hubspot__contacts.sql
@@ -1,5 +1,5 @@
 {{ config(enabled=fivetran_utils.enabled_vars(['hubspot_marketing_enabled', 'hubspot_contact_enabled'])) }}
-{% set emails_enabled = fivetran_utils.enabled_vars(['hubspot_marketing_enabled', 'hubspot_email_event_enabled']) %}
+{% set emails_enabled = fivetran_utils.enabled_vars(['hubspot_marketing_enabled', 'hubspot_email_event_enabled', 'hubspot_email_event_sent_enabled']) %}
 {% set engagements_enabled = fivetran_utils.enabled_vars(['hubspot_sales_enabled', 'hubspot_engagement_enabled','hubspot_engagement_contact_enabled']) %}
 
 with contacts as (

diff --git a/models/marketing/hubspot__email_campaigns.sql b/models/marketing/hubspot__email_campaigns.sql
@@ -1,4 +1,4 @@
-{{ config(enabled=fivetran_utils.enabled_vars(['hubspot_marketing_enabled','hubspot_email_event_enabled'])) }}
+{{ config(enabled=fivetran_utils.enabled_vars(['hubspot_marketing_enabled','hubspot_email_event_enabled','hubspot_email_event_sent_enabled'])) }}
 
 
 with campaigns as (

diff --git a/models/marketing/intermediate/int_hubspot__email_metrics__by_contact_list.sql b/models/marketing/intermediate/int_hubspot__email_metrics__by_contact_list.sql
@@ -1,4 +1,4 @@
-{{ config(enabled=fivetran_utils.enabled_vars(['hubspot_marketing_enabled','hubspot_email_event_enabled','hubspot_contact_list_member_enabled','hubspot_contact_enabled']), materialized='table') }}
+{{ config(enabled=fivetran_utils.enabled_vars(['hubspot_marketing_enabled','hubspot_email_event_enabled','hubspot_contact_list_member_enabled','hubspot_contact_enabled','hubspot_email_event_sent_enabled']), materialized='table') }}
 
 with email_sends as (