-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.15.0 #127
Release/v0.15.0 #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz thanks for working through these! I ultimately don't have many comments on these changes, but want to hold off approving until the upstream changes are addressed from the source package. Let me know once the upstream and these comments are address so I may do a final review. Thanks!
packages.yml
Outdated
# version: [">=0.14.0", "<0.15.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_hubspot_source.git | ||
revision: release/v0.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to switch before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fivetran-joemarkiewicz! I have updated to be in line with the changes made in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go with some minor comments to be sure to update the version bump in the README.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
(PR #127) includes the following updates:
🚨 Breaking Changes 🚨
property_hs_*
column, you now have the option to include the corresponding, human-readable label in the staging models.hubspot__company
hubspot__contact
hubspot__deal
hubspot__ticket
Bug fixes
hubspot__contacts
to also check variablehubspot_engagement_contact_enabled
.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps: