Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.15.0 #127

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Release/v0.15.0 #127

merged 11 commits into from
Nov 15, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Nov 13, 2023

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • v0.15.0
  • Breaking due to changes in the source.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

(PR #127) includes the following updates:

🚨 Breaking Changes 🚨

  • When including a passthrough property_hs_* column, you now have the option to include the corresponding, human-readable label in the staging models.
    • See the Adding property label section of the README for instructions on how to enable this feature!
    • This update applies to models:
      • hubspot__company
      • hubspot__contact
      • hubspot__deal
      • hubspot__ticket

Bug fixes

  • Updated variables used to determine if engagements are enabled in hubspot__contacts to also check variable hubspot_engagement_contact_enabled.
  • See the dbt_hubspot_source CHANGELOG for more details on fixes included in the source package.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • See ticket for validation link.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz thanks for working through these! I ultimately don't have many comments on these changes, but want to hold off approving until the upstream changes are addressed from the source package. Let me know once the upstream and these comments are address so I may do a final review. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages.yml Outdated
Comment on lines 2 to 6
# version: [">=0.14.0", "<0.15.0"]

- git: https://github.com/fivetran/dbt_hubspot_source.git
revision: release/v0.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to switch before merging

Copy link
Contributor Author

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fivetran-joemarkiewicz! I have updated to be in line with the changes made in the source.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go with some minor comments to be sure to update the version bump in the README.

README.md Show resolved Hide resolved
@fivetran-catfritz fivetran-catfritz merged commit baf5228 into main Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants