feature/quickstart-yml-add #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fivetran-reneeli this PR is meant to include the |
|
merging in! I looked at why buildkite is failing and it's because of the updates I pushed in the source of correcting the default config for merged_deals to be false, but not here. should pass once i merge into my updated branch. other thing is adding hubspot_merged_deal_enabled to the quickstart yml as well |
| - ticket_property_history | ||
| - ticket | ||
| hubspot_ticket_deal_enabled: | ||
| - ticket_deal |
There was a problem hiding this comment.
We'll need to add one for hubspot_merged_deal_enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to incorporate the quickstart.yml into the next release.
Additionally, I added extra config logic to handle a bug highlighted here. I was able to test and confirmed that this should address the bug initially raised by some quickstart users.