v0.19.0- upstream breaking changes #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
@fivetran-reneeli LGTM! Just one small CHANGELOG update required before moving to release review.
packages.yml
Outdated
Comment on lines
2
to
7
| # version: [">=0.16.0", "<0.17.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_hubspot_source.git | ||
| revision: bugfix/column_quote_all_passthrough_columns | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to update before merge.
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
integration_tests/dbt_project.yml
Outdated
| # hubspot__company_pass_through_columns: | ||
| # - name: "property_hs_all-funky-a9384-syntax" | ||
| # alias: "funky_field" | ||
| hubspot_sales_enabled: true # enable when generating docs |
There was a problem hiding this comment.
We should comment lines 16-17 out before merging?
There was a problem hiding this comment.
thanks! Yes will comment out the unnecessary configs
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fivetran-avinash
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
@fivetran-reneeli (Sorry, ignore previous comment) One suggestion and then this is ready to release once the source is approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
In combination with fivetran/dbt_hubspot_source#129
This PR will result in the following new package version: 0.19.0
Breaking due to breaking changes in the upstream package.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Breaking Changes
hubspot__pass_through_all_columnsandhubspot__<>_pass_through_columns, this may be a breaking change due to leveraging theremove_duplicate_and_prefix_from_columnsmacro. This is a breaking change because this macro can remove duplicate fields, resulting in an impact to your schema. For more information refer to the upstream dbt_hubspot_source v0.15.0 release notes.Under the Hood
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
see internal ticket
If you had to summarize this PR in an emoji, which would it be?
💃