Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce category field upstream #150

Merged
merged 17 commits into from
Nov 11, 2024
Merged

introduce category field upstream #150

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
69ea5e4
versioning
fivetran-reneeli Nov 1, 2024
8ee9fe1
temp depedency and update changelog
fivetran-reneeli Nov 4, 2024
8c98a25
i dont think docs regen is needed but just in case
fivetran-reneeli Nov 4, 2024
fb3c82f
ensure seed data from source is the same as in transforms
fivetran-reneeli Nov 5, 2024
5d84090
updaet changelog
fivetran-reneeli Nov 5, 2024
e349f40
integration test fixes
fivetran-reneeli Nov 5, 2024
d59dec1
update seed configs
fivetran-reneeli Nov 6, 2024
959d264
explicit cast for pipeline_id
fivetran-reneeli Nov 7, 2024
27b2961
more datatype casting
fivetran-reneeli Nov 7, 2024
3caa4d5
docs
fivetran-reneeli Nov 7, 2024
ea641c5
new schema
fivetran-reneeli Nov 7, 2024
2b6950e
Update CHANGELOG.md
fivetran-reneeli Nov 8, 2024
02f3698
rm category from merged_deal and comment out variables in integration…
fivetran-reneeli Nov 8, 2024
f6f9e7d
new schema
fivetran-reneeli Nov 8, 2024
948dbfe
updates
fivetran-reneeli Nov 11, 2024
753f5b3
updates
fivetran-reneeli Nov 11, 2024
f180d8b
change deps
fivetran-reneeli Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# dbt_hubspot v0.20.0
[PR #150](https://github.com/fivetran/dbt_hubspot/pull/150) includes the following updates:

## Breaking Change (`--full-refresh` required after upgrading)
- Introduced the new `category` column to certain upstream models and added to relevant unique tests. This association field differentiates records by either HUBSPOT_DEFINED (default label) or USER_DEFINED (custom label) and was introduced to the connector in October 2024. For more information, refer to the upstream [CHANGELOG](https://github.com/fivetran/dbt_hubspot_source/releases/tag/v0.17.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's exhaustive, but can you include essentially the entire breaking change note from the source CHANGELOG to be here as well. We can still link to the source release notes, but since this is what is rendered in the Quickstart UI, it would be great to show all relevant breaking changes here without requiring the customer to click through a new link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no prob, that makes sense! added the note from source in its entirety


- This will be a breaking change and will require a `--full-refresh`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this since we already mention it in the title header.


# dbt_hubspot v0.19.1
[PR #148](https://github.com/fivetran/dbt_hubspot/pull/148) includes the following updates:

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Include the following hubspot package version in your `packages.yml` file:
```yaml
packages:
- package: fivetran/hubspot
version: [">=0.19.0", "<0.20.0"] # we recommend using ranges to capture non-breaking changes automatically
version: [">=0.20.0", "<0.21.0"] # we recommend using ranges to capture non-breaking changes automatically

```
Do **NOT** include the `hubspot_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well.
Expand Down Expand Up @@ -317,7 +317,7 @@ This dbt package is dependent on the following dbt packages. These dependencies
```yml
packages:
- package: fivetran/hubspot_source
version: [">=0.16.0", "<0.17.0"]
version: [">=0.17.0", "<0.18.0"]

- package: fivetran/fivetran_utils
version: [">=0.4.0", "<0.5.0"]
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'hubspot'
version: '0.19.1'
version: '0.20.0'

config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'hubspot_integration_tests'
version: '0.19.1'
version: '0.20.0'

profile: 'integration_tests'
config-version: 2
Expand Down
8 changes: 6 additions & 2 deletions packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
packages:
- package: fivetran/hubspot_source
version: [">=0.16.0", "<0.17.0"]
# - package: fivetran/hubspot_source
# version: [">=0.17.0", "<0.18.0"]

- git: https://github.com/fivetran/dbt_hubspot_source.git
revision: bugfix/category_add
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the above.