Deal stage updates #37
Conversation
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
| description: The unique deal stage identifier. | ||
| tests: | ||
| - not_null | ||
| - unique |
There was a problem hiding this comment.
i think this might not always pass since we're pulling in deal_company, which has a 1:n relationship
There was a problem hiding this comment.
maybe we shouldn't bring the company into the deal_stages model, which is what we decided with hubspot__deals (and users can just join with deal_company and company using the staging models)
There was a problem hiding this comment.
Ahh I forgot about that issue. That is a great point. I will remove the deal_company and refer the customer that they can simply join company in if they would like. Thanks!
There was a problem hiding this comment.
Hello @fivetran-jamie and @fivetran-joemarkiewicz,
I dug through the documentation of dbt_hubspot as well as dbt_hubspot_source's but saw nothing about "simply joining company" as per the last comment here. How would you go about including the company_id in hubspot_deals without adding a custom field on Hubspot or having to build a child table only to join deal_company?
Thanks for your help, and thanks for this incredible package!
Edit:
This is what I ended up doing! Works like a charm. Is this the kind of thing you had in mind when you wrote about "refering the customer" ? I feel like it could be a great addition to the README, and would be happy to open a PR if need be.
-- models/marts/facts/hubspot__deal_company.sql
{{ config(schema='hubspot') }}
SELECT * FROM {{ source('hubspot', 'deal_company') }}There was a problem hiding this comment.
Hi @coisnepe the deal_company model does exist within the source package as a staging model (stg_hubspot__deal_comapny). @fivetran-jamie was referring to using this staging model to join in the company information to the deal_stages model. If you leverage this, I believe would you achieve the same results.
Let me know if this works!
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
…hubspot into deal_stage-updates
| @@ -0,0 +1,63 @@ | |||
| {{ config(enabled=fivetran_utils.enabled_vars(['hubspot_sales_enabled','hubspot_deal_enabled'])) }} | |||
There was a problem hiding this comment.
Thought here ---
Why did you choose this approach, rather than joining the new deal_stage model to the final hubspot__deals model? Seems like we're doing a lot of duplicative work in this model, but I may be missing something.
There was a problem hiding this comment.
You're right this is duplicative work. The only difference is the inclusion of the pipeline.is_active which is not in the hubspot__deals model. I will add that field to the hubspot__deals model to make this a cleaner model and remove duplicative code. Thanks!
|
When updating the As such, to accommodate for this and produce cleaner code I decided to create an intermediate model |
This PR includes the following updates:
hubspot__deal_stagefinal model as requested within Issue Feature Request - Deal_stage modeling #30hubspot_deal_company_enabledvariable