Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix merge conflicts + remove trailing spaces #80

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

cristianwebber
Copy link
Contributor

Pull Request
Are you a current Fivetran customer?
Cristian, data engineer doing Fivetran POC

What change(s) does this PR introduce?
This PR fix the merge conflicts and remove trailing spaces in README file.

Did you update the CHANGELOG?

  • Yes
  • No, sure sure if it's necessary.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes
  • No, sure sure if it's necessary.

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristianwebber thank you so much for catching these holdover merge artifacts. 🤦

I added a small commit to your PR to reflect your contribution and increase the version of the package. We really appreciate your vigilance and contribution to our codebase. I will merge this and include the updates within our next release.

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants