Correct config variable name in README #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
changed the base branch from
main
to
MagicBot/dbt-utils-cross-db-migration
fivetran-reneeli
merged commit b44c376
into
fivetran:MagicBot/dbt-utils-cross-db-migration
|
Hi @MarcelloMolinaro thank you for noticing and raising this! Your fix makes complete sense. Merged into our upcoming release ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85
Are you a current Fivetran customer?
Yes
What change(s) does this PR introduce?
Readme fix
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
hubspot_engagement_call_enabledvariable misspelled on README #85]How did you test the PR changes?
I searched the package for
hubspot_engagement_calls_enabledandhubspot_engagement_call_enabled....calls...only appears in the README while...call...appears in both the hubspot__engagement_calls.sql model and the manifest.json (see below)Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
✏️ (first open source contribution)
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.