Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databricks #89

Merged

Conversation

fivetran-jamie
Copy link
Collaborator

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

databricks compatibility

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

the migration branch which is its base is a breaking change

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🧱

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jamie!

This looks good to me - hopefully Buildkite can pass in a reasonable amount of time before merge.

packages.yml Outdated
- git: https://github.com/fivetran/dbt_hubspot_source.git
revision: MagicBot/dbt-utils-cross-db-migration
revision: feature/databricks-compat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to switch before merge

@fivetran-jamie fivetran-jamie merged commit 7e2ebfa into MagicBot/dbt-utils-cross-db-migration Nov 15, 2022
@fivetran-jamie fivetran-jamie deleted the feature/databricks-compat branch November 15, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants