updating models #92
Merged
updating models #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
fivetran-jamie
requested changes
Jan 6, 2023
models/marketing/intermediate/int_hubspot__email_metrics__by_contact_list.sql
Outdated
Show resolved
Hide resolved
packages.yml
Outdated
| # - package: fivetran/hubspot_source | ||
| # version: [">=0.7.0", "<0.8.0"] | ||
| - git: https://github.com/fivetran/dbt_hubspot_source.git |
There was a problem hiding this comment.
obligatory reminder to update before merging
| @@ -323,11 +323,8 @@ models: | |||
| - name: hubspot__contact_lists | |||
| description: Each record represents a contact list in Hubspot. | |||
| columns: | |||
| - name: _fivetran_deleted | |||
There was a problem hiding this comment.
we need to add is_contact_list_deleted right?
| @@ -206,11 +206,11 @@ models: | |||
| - name: hubspot__contacts | |||
| description: Each record represents a contact in Hubspot. | |||
| columns: | |||
| - name: _fivetran_deleted | |||
| description: '{{ doc("_fivetran_deleted") }}' | |||
| - name: is_contact_deleted | |||
There was a problem hiding this comment.
i think hubspot__email_sends is missing this
| [PR #92](https://github.com/fivetran/dbt_hubspot/pull/92) incorporates the following changes: | ||
|
|
||
| - The below models/macros have new soft deleted record flags **explicitly** added to them: | ||
| - `is_contact_deleted` added in `macros/email_events_joined` which can affect the following downstream models found in `models/marketing/email_events/`: |
There was a problem hiding this comment.
hubspot__email_sends as well i think
fivetran-jamie
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran employee
What change(s) does this PR introduce?
Features
Soft deleted records are now included in the below models/macros:
macros/email_events_joinedmodels/marketing/intermediate/int_hubspot__email_metrics__by_contact_listmodels/sales/intermediate/int_hubspot__deals_enhancedmodels/sales/deal_stagesSoft deleted records can now be removed by using the following respective flags for the above models:
is_contact_list_member_deletedis_deal_pipeline_deletedis_deal_pipeline_stage_deletedis_deal_deletedDid you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.