Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Hub models #27

Closed
jamesrayoub opened this issue Feb 18, 2021 · 4 comments
Closed

Add Service Hub models #27

jamesrayoub opened this issue Feb 18, 2021 · 4 comments

Comments

@jamesrayoub
Copy link
Contributor

Fivetran added the Service Hub tables to the connector last year and the following staging models should be created

  • ticket
  • ticket_company
  • ticket_contact
  • ticket_deal
  • ticket_engagement
  • ticket_property_history
@jamesrayoub
Copy link
Contributor Author

opened #28 to address this

@fivetran-joemarkiewicz
Copy link
Contributor

Hi @jamesrayoub PR #30 implements the Service Hub changes you initiated within PR #28. We are holding off merging the PR to master until the additional tables you requested with the Support Portal are added at the connector level. This way we may fully capture the Service Hub models.

@jamesrayoub
Copy link
Contributor Author

Great, thanks for the update @fivetran-joemarkiewicz

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Mar 30, 2021

Hi @jamesrayoub, I was able to add the ticket_pipeline and ticket_pipeline_stage tables to service-hub-updates branch!

Additionally, in response to your PR #35 I leveraged the code you provided and integrated it with how we have handled pass through columns in the past. The modifications I made should hopefully make declaring the variable a bit easier and will be consistent with our previous package pass through variables.

The approach I took was to only provide the opinionated "standard" fields for the company, contact, deal, and ticket within the respective macros and staging models, then use a conditional break to call the variables the customer will set to pass them through to the final staging model.

Let me know if you have any questions on this approach. Also, feel free to install this working branch as a dependency prior to us merging to master and releasing a new version as I would greatly appreciate your feedback and contributions beforehand!

packages:
  - git: https://github.com/fivetran/dbt_hubspot_source.git
    revision: service-hub-updates
    warn-unpinned: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants