Service hub updates #30
Conversation
Model HubSpot Service Hub tables
fivetran-joemarkiewicz
requested review from
fivetran-jamie and
kristin-bagnall
integration_tests/dbt_project.yml
Outdated
| @@ -97,3 +108,9 @@ seeds: | |||
| engagement_note_data: | |||
| +column_types: | |||
| engagement_id: "{{ 'int64' if target.name == 'bigquery' else 'bigint' }}" | |||
| ticket_company_data: | |||
There was a problem hiding this comment.
do we need to add these if we're not configuring any column types or anything?
There was a problem hiding this comment.
We most likely don't. They were carried over in case I needed to do any column config for seed data that I never ended up using. I can remove!
models/stg_hubspot__contact.sql
Outdated
| @@ -10,7 +10,7 @@ with base as ( | |||
|
|
|||
| select | |||
| id as contact_id, | |||
| {{ fivetran_utils.remove_prefix_from_columns(columns=columns, prefix='property_', exclude=['id']) }} | |||
| {{ fivetran_utils.remove_prefix_from_columns(columns=columns, prefix='property_', exclude=['id', 'contact_id']) }} | |||
There was a problem hiding this comment.
is contact_id supposed to be property_contact_id? based on https://github.com/fivetran/dbt_hubspot_source/pull/9/files
|
This PR also incorporates the ideas provided by @jamesrayoub within PR #35 to allow users to add additional configuration to pass through columns and dynamically handle them within the staging models via newly added Fivetran utils. These new fivetran utils are currently in an open PR and this should not be merged until the fivetran utils is merged and dependency is switched in this package. |
packages.yml
Outdated
| @@ -3,4 +3,5 @@ packages: | |||
| version: [">=0.6.0", "<0.7.0"] | |||
|
|
|||
| - git: "https://github.com/fivetran/dbt_fivetran_utils.git" | |||
| revision: add-passthrough-macro | |||
There was a problem hiding this comment.
update after merging
There was a problem hiding this comment.
this looks good to me! we'll just need to make it very clear in the release that the deal/contact/company models now only bring a few columns by default, and that users will very likely/almost certainly have to use passthrough columns (and that they'll be a ton more flexible/useful than before)
This PR includes the following changes:
- Please note this PR currently is missing the
pipelinesandpipelines_stagesmodels. A request is currently out for the Fivetran connector to include these tables. Once the tables are included at the connector level we will incorporate them within the PRAddress thecontact_idbug called out within PR Maintain support for dbt 0.17.2 #9