Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

James feedback #37

Merged
merged 7 commits into from
Apr 9, 2021
Merged

James feedback #37

merged 7 commits into from
Apr 9, 2021

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@jamesrayoub was able to test the package after the merge of PR #30 and had a few recommendations for adding default fields to the company, contact, deal, and ticket models. We leveraged the HubSpot documentation for selected the opinionated default fields to be included within the staging models. See below for the links used to select the default fields:

Additionally, this PR includes the following updates:

  • Github pages docs update
  • yml updates
  • CircleCi seed data updates
  • Updating pipeline_id to ticket_ pipeline_id for consistency across models

@jamesrayoub
Copy link
Contributor

@fivetran-joemarkiewicz ticket_pipeline_stage.stage_id should also be changed toticket_pipeline_stage_id. That's reflective of the deal pipeline stage naming

Copy link
Contributor

@kristin-bagnall kristin-bagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit ade9860 into master Apr 9, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the james-feedback branch April 9, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants