Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal stage and postgres updates #36

Merged
merged 7 commits into from
Apr 2, 2021
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

This PR includes the following updates:

  • Addition of the deal_stage model in response to dbt_hubspot Issue
  • Postgres compatibility
  • Addition of the hubspot_deal_company variable as the dataset being used to test this addition did not contain this table and felt it was appropriate to include the option to disable if desired.

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! with this and the service PR, should we increase the version to 0.3.1?

@fivetran-joemarkiewicz
Copy link
Contributor Author

Updated to v0.3.1 as well as dag and yml cleanup for ticket models (switched var to ref so dag isn't as spaghetti like. Finally, updated docs to reflect updates.

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 878d7be into master Apr 2, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the deal-stage-updates branch April 2, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants