removing unused engagement models #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Thanks for catching this and turning it around so quickly @fivetran-sheringuyen!!
I only have a quick request to update the CHANGELOG and also add the same version index to the dbt_project.yml. Other than that, this PR looks good to ship!
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| name: 'hubspot_source_integration_tests' | |||
| version: '0.5.1' | |||
| version: '0.5.2' | |||
There was a problem hiding this comment.
Can you also update the dbt_project.yml version to reflect the same version.
CHANGELOG.md
Outdated
| # dbt_hubspot_source v0.5.2 | ||
|
|
||
| ### Updates | ||
| - Removing unused models `stg_hubspot__engagement_email_cc` and `stg_hubspot__engagement_email_to` from `stg_hubspot__engagement.yml` |
There was a problem hiding this comment.
Can you add this PR to this CHANGELOG update.
Suggested change
| - Removing unused models `stg_hubspot__engagement_email_cc` and `stg_hubspot__engagement_email_to` from `stg_hubspot__engagement.yml` | |
| - Removing unused models `stg_hubspot__engagement_email_cc` and `stg_hubspot__engagement_email_to` from `stg_hubspot__engagement.yml` ([#56](https://github.com/fivetran/dbt_hubspot_source/pull/56)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran employee
What change(s) does this PR introduce?
Removing unused models from stg_hubspot__engagement.yml
Does this PR introduce a breaking change?
Is this PR in response to a previously created Issue
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.