Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disable ticket deal and apply DEAL property renaming fix #79

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Aug 18, 2022

Pull Request
Are you a current Fivetran customer?

fivetran made pr

What change(s) does this PR introduce?

  1. adds disabling variable to ticket_deal
  2. consistently renames property columns in deals staging model

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes
  • No because this is getting merged into a release branch that is already doing that

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🕴️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie fivetran-jamie changed the title Feature/disable ticket deal Feature/disable ticket deal and apply DEAL property renaming fix Aug 23, 2022
@fivetran-jamie
Copy link
Contributor Author

actually this is a breaking change so will need to update package version @fivetran-reneeli

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fivetran-reneeli fivetran-reneeli merged commit 9b64767 into release/v0.3.8 Aug 24, 2022
@fivetran-reneeli fivetran-reneeli deleted the feature/disable-ticket-deal branch August 24, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants