Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust intermediate model logic for unique total counts #34

Merged

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Aug 7, 2023

PR Overview

This PR will address the following Issue/Feature: [#29]

This PR will result in the following new package version: 0.9.1

As only field logic was being modified to reflect new values, only a patch update was needed.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

  • Adjusted intermediate model logic in int_iterable__campaign_event_metricsl to correctly count unique totals based off of distinct email values for iterable__campaigns.
  • Added additional join on template_id in iterable__campaigns so the proper grain is being reflected.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

I made sure my changes did not impact any of the immediate unique values since I could not find a case where the bug actually impacted our development data. So I focused on ensuring values on the test branch matched

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • [NA] README updates have been applied (if applicable)
  • [NA] DECISIONLOG updates have been updated (if applicable)
  • [NA] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💠

@fivetran-avinash fivetran-avinash self-assigned this Aug 7, 2023
@fivetran-avinash fivetran-avinash marked this pull request as ready for review August 7, 2023 09:16
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request to update the CHANGELOG wording. Other than that, this looks good to go!

CHANGELOG.md Outdated

## 🪲 Bug Fix ⚒️
- Adjusted intermediate model logic in `int_iterable__campaign_event_metrics` to correctly count unique totals based off of distinct email values for `iterable__campaigns`.
- Added additional join on `template_id` in `int_iterable__recurring_campaigns` to resolve test errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does resolve the test, but the more important piece is how it removes the fanout.

Suggested change
- Added additional join on `template_id` in `int_iterable__recurring_campaigns` to resolve test errors.
- Added additional join on `template_id` in `int_iterable__recurring_campaigns` to resolve a data fanout issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@fivetran-avinash fivetran-avinash merged commit a2f2ecc into main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unique events ( opens, clicks, conversions) are being counted multiple times
2 participants