-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust intermediate model logic for unique total counts #34
Adjust intermediate model logic for unique total counts #34
Conversation
…://github.com/fivetran/dbt_iterable into bugfix/correctly-count-unique-campaign-totals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request to update the CHANGELOG wording. Other than that, this looks good to go!
CHANGELOG.md
Outdated
|
||
## 🪲 Bug Fix ⚒️ | ||
- Adjusted intermediate model logic in `int_iterable__campaign_event_metrics` to correctly count unique totals based off of distinct email values for `iterable__campaigns`. | ||
- Added additional join on `template_id` in `int_iterable__recurring_campaigns` to resolve test errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does resolve the test, but the more important piece is how it removes the fanout.
- Added additional join on `template_id` in `int_iterable__recurring_campaigns` to resolve test errors. | |
- Added additional join on `template_id` in `int_iterable__recurring_campaigns` to resolve a data fanout issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
PR Overview
This PR will address the following Issue/Feature: [#29]
This PR will result in the following new package version: 0.9.1
As only field logic was being modified to reflect new values, only a patch update was needed.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
int_iterable__campaign_event_metrics
l to correctly count unique totals based off of distinct email values foriterable__campaigns
.template_id
initerable__campaigns
so the proper grain is being reflected.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
iterable__campaigns
#35))Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
I made sure my changes did not impact any of the immediate unique values since I could not find a case where the bug actually impacted our development data. So I focused on ensuring values on the test branch matched
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💠