Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add union data #104

Open
wants to merge 20 commits into
base: release/v0.13.0-apr-2024
Choose a base branch
from

Conversation

fivetran-poonamagate
Copy link

Please provide your name and company
Poonam Agate, Fivetran

Link the issue/feature request which this PR is meant to address

N/A

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Provides the capability to union multiple Netsuite connectors together and leverage the source dependent models in this package

How did you validate the changes introduced within this PR?
Run the models amended in BigQuery

Which warehouse did you use to develop these changes?
BigQuery

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie @fivetran-poonamagate great job on these PRs! I only have a few comments, but these look good to go with just a few comments to be addressed before merging.

@@ -0,0 +1,35 @@
name: 'check docs'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same request as others to remove this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

README.md Outdated

<details><summary><i>Expand for source configuration template</i></summary><p>

> **Note**: If there are source tables you do not have (see [Step 4](https://github.com/fivetran/dbt_netsuite?tab=readme-ov-file#step-5-disable-models-for-non-existent-sources-netsuite2-only)), you may still include them, as long as you have set the right [variables](https://github.com/fivetran/dbt_netsuite?tab=readme-ov-file#step-5-disable-models-for-non-existent-sources-netsuite2-only) to `False`. Otherwise, you may remove them from your source definitions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on asking how we can make this easier to maintain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment on lines +2 to +6
# - package: fivetran/netsuite_source
# version: [">=0.9.0", "<0.10.0"]
- git: https://github.com/fivetran/dbt_netsuite_source.git
revision: feature/add-union-data
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release

@fivetran-catfritz fivetran-catfritz changed the base branch from main to release/v0.13.0-apr-2024 April 11, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants