Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Databricks compatibility #13

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented May 17, 2023

Confirm the following files were correctly updated automatically:

  • hooks/pre-command line added
  • pipeline.yml section added
  • sample.profiles.yml catalog updated
  • integration_tests/dbt_project.yml section added (check for dupes though)
  • Version updates for dbt_project.yml and integration_tests/dbt_project.yml (automatically moved to next breaking change)
  • Changelog (automatically moved to next breaking change, but check the PR links were added correctly!)

Manual updates are:

  • README
  • packages.yml for transform packages
  • Incremental Models
  • Regen Docs
  • Local Databricks run and test passing
  • Buildkite passing

@fivetran-catfritz fivetran-catfritz linked an issue Jun 20, 2023 that may be closed by this pull request
4 tasks
packages.yml Outdated
Comment on lines 2 to 7
# - package: fivetran/pardot_source
# version: [">=0.6.0", "<0.7.0"]

- git: https://github.com/fivetran/dbt_pardot_source.git
revision: MagicBot/databricks-compatibility
warn-unpinned: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update before merge/release.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-catfritz fivetran-catfritz merged commit 9b27836 into main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Databricks Compatibility
2 participants