Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Ad Reporting Issue #77
This PR will result in the following new package version:
v0.7.1
This will not be a breaking change as it is only including a new variable to allow users to disable the keyword reports. This will have no impact on existing users, but will allow users to configure their package more uniquely based on their source schema.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR includes a new variable
pinterest__using_keywords
that allows users to disable the keywords reports within Pinterest if they are not needed or are not located within the users source schema.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
This PR was validated by ensuring the keyword reports were not included in the run if the
pinterest__using_keywords
variable was defined asfalse
. Similarly, this was tested inversely to ensure they were included if the variable was set totrue
or not defined at all (testing the default behavior).Variable set to
false
Variable set to
true
Variable not defined (default)
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📚