-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversions #34
Add conversions #34
Conversation
…sion data and passthrough macro
…er plus comment out test configs and add models config
packages.yml
Outdated
# - package: fivetran/pinterest_source | ||
# version: [">=0.11.0", "<0.12.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_pinterest_source.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me! I just have one documentation question in the DECISIONLOG before approving for release.
integration_tests/dbt_project.yml
Outdated
# models: | ||
# +schema: "pinterest_ads_{{ var('directed_schema','dev') }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be commented back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Overview
This PR will address the following Issue/Feature:
Internal ticket, to add conversions data
This PR will result in the following new package version:
0.11.0
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Feature update
pinterest_ads
end model:total_conversions
total_conversions_quantity
total_conversions_value_in_micro_dollar
Under the hood
pinterest_ads_persist_pass_through_columns
macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.integration_tests
folder for the transformation models (to be used by maintainers only).PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
horizontal_sum_conversions
vertical_sum_conversions
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💃