Update int_quickbooks__sales_receipt_double_entry.sql #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated line 39 amount to a case statement flipping the sign for all sales receipt discounts.
4 tasks
fivetran-avinash
merged commit 95fae91
into
fivetran:bugfix/sales-receipt-debit-should-be-negative
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated line 39 amount to a case statement flipping the sign for all sales receipt discounts.
Please provide your name and company
Render Analytics
Link the issue/feature request which this PR is meant to address
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Discounts for Sales Receipts were coming into the GL as Positive values but discounts on Sales Receipts should be negative for both debits and credits for the GL to balance. This PR solves that.
How did you validate the changes introduced within this PR?
I implmented a new package inversing polarity on Sales Receipt discounts. Ran the DBT job against our live quickbooks data and made sure the GL balanced. I can confirm that it does.
Which warehouse did you use to develop these changes?
Bigquery
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)