Fix divide by zero error

[fivetran-avinash]

PR Overview

This PR will address the following Issue/Feature: [#137]

This PR will result in the following new package version: 0.14.1

No fields are changed, just the logic of how some fields are calculated.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

• Added nullif logic to account for "divide by zero" errors in int_quickbooks__deposit_double_entry and int_quickbooks__deposit_transactions for when total_amount values from the deposit source table
  are zero.

Under the Hood

• Added integrity test within integration tests to compare deposit amounts between int_quickbooks__deposit_double_entry and deposit transaction_type values in quickbooks__general_ledger.
• Modified seed files in integration_tests to reproduce issue and confirm fixes.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

After modifying the seed files, we were able to reproduce the error. customers were experiencing.

Adding the nullif logic resolved the errors.

We also constructed an additional integrity test deposit_ledger_amounts_match to ensure that there are no discrepancies on amounts from the new logic.

If you had to summarize this PR in an emoji, which would it be?

0️⃣

[fivetran-reneeli]

I'd also just drop the name of the actual integrity test to make it more straightforward

[fivetran-avinash]

Changed!

[fivetran-reneeli]

Looks good! Approved with just 1 small working comment in the Changelog.