fixing bug for salesforce_user passthrough columns #32
Conversation
|
@fivetran-joemarkiewicz any feedback on this PR? Would love to get it merged, we are having a recurring failure for this bug that is causing some unnecessary noise. |
|
Hey @calder-holt thank you so much for raising this. We're working on making these changes this current sprint! |
There was a problem hiding this comment.
@calder-holt Thank you so much for opening this PR! We really appreciate you taking the proactive steps to creating this.
For that one change you made and we suggested changes for, would you be able to make the same changes for the other passthrough variables in the final models so that the proper logic applies to all additional Salesforce fields?
Let me know if you have any questions or feedback!
|
Hey @calder-holt! Hope you had a great weekend. If you have the time, we'd love if you could apply the recommended changes--otherwise we can try and commit additional code up later in the week. Also happy to chat through it if you have any thoughts or questions. Cheers! |
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
|
@fivetran-avinash I have committed the suggested changes, thanks! |
There was a problem hiding this comment.
Hi @calder-holt! Thanks for applying these changes!
Apologies for not being clearer--the change I suggested has to be applied to all the Salesforce models or they will also experience the same issues.
So for salesforce__contact_enhanced, you'd want to add those variable names in front of the other fields where {{ var('contact_pass_through_columns')}} exists, similar to what you did with salesforce_user.
Likewise, you'll want to do the same on salesforce__opportunity_line_item_enhanced.
Let me know if that makes sense! Happy to clarify further.
| @@ -65,7 +65,7 @@ select | |||
| {% endif %} | |||
|
|
|||
| {% if var('user_pass_through_columns',[]) != [] %} | |||
| , {{ var('user_pass_through_columns') | join (", user.")}} | |||
| , salesforce_user.{{ var('user_pass_through_columns') | join (", salesforce_user.")}} | |||
There was a problem hiding this comment.
Nice work with the changes!
Sorry for the confusion. To make sure we're accounting for all additional potential issues, you will also want to make the same changes for the other joins in line 58 (adding contact. in front of {{ var('contact_pass_through_columns')) and line 63 (adding account. in front of {{ var('contact_pass_through_columns')).
You will want to replicate these changes for salesforce__opportunity_line_item_enhanced model as well on the oli (on line 61) and product_2 (on line 66) joins as well!
|
Hey @calder-holt ! Just wanted to see if you were planning to work on the suggested changes today! If time doesn't permit for you, we will apply them from our end later this afternoon. Thanks again for all your contributions! |
fivetran-avinash
changed the base branch from
main
to
customer/passthrough_fix
There was a problem hiding this comment.
Thanks so much @calder-holt! I'll be merging your code into our PR where we'll make the final changes, and you should see the new release by this time tomorrow!
Pull Request
Are you a current Fivetran customer?
Holt Calder, Data Engineering Manager, Greenhouse Software
What change(s) does this PR introduce?
Resolving bug in salesforce_contact_enhanced for user passthrough columns.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Existing functionality was not working.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.