Bug/update disabling models #35
Conversation
fivetran-catfritz
requested review from
fivetran-joemarkiewicz and
fivetran-avinash
and removed request for
fivetran-joemarkiewicz
README.md
Outdated
|
|
||
| The `salesforce__user_role_enabled` variable below refers to the `user_role` table. | ||
| To disable the corresponding functionality in this package, you must add the corresponding variable(s) to your `dbt_project.yml`, which are listed below. By default, that is if none of these variables are added, all variables are assumed to be true. Add variables only for the tables you would like to disable: | ||
|
|
||
| ```yml | ||
| # dbt_project.yml |
There was a problem hiding this comment.
I think you can remove lines 82-86 with the commented out dbt_project.yml and config-version: 2 line. Same with lines 66-70.
There was a problem hiding this comment.
Thanks, and I have updated. I also updated similarly in a few other similar code blocks for consistency.
There was a problem hiding this comment.
Hello @fivetran-catfritz! Everything looks good, just some minor tweaks to clean up the Readme.
One other thing--if you can update your integration_tests/requirements.txt files to the following specs below and include it in the PR. Joe mentioned that we should start updating requirements files going forward since the original 1.0.0 versions are starting to throw errors, just something to keep in mind!
|
@fivetran-avinash I have updated the pushed the requirements and readme changes! |
Pull Request
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Bug Fixes
dbt_project.ymlto avoid potential conflict with a user's settings.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🐧
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.