bug/renamed-columns-datespine

[fivetran-catfritz]

PR Overview

This PR will address the following Issue/Feature:

• T-707421

This PR will result in the following new package version:

• v1.1.1 since this is a logic change and is a patch to the last release.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bugfix

• Updated the logic for model int_salesforce__date_spine to reference the stg_* staging models instead of the source tables.
  • This was necessary since the staging models account for multiple spellings of column names while the source tables do not.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Making sure the issue is corrected

1. Created seed table with column CreatedDate and without created_date.
2. Reproduced the issue with the production package

• 

3. Corrected the issue with this update

• 

Ensuring consistency between versions

• Final model salesforce__daily_activity is downstream of the date spine.
• 

If you had to summarize this PR in an emoji, which would it be?

🎏

[fivetran-catfritz]

This is still necessary for dbt run. I tried running without it, and the error said to put it back. It's still not necessary for compilation, however.

[fivetran-joemarkiewicz]

@fivetran-catfritz thanks for the quick resolution here! This change looks good to me. I just have one request to add an additional note to the CHANGELOG; however, that doesn't need to be blocking the review - as long as it is applied before the release review is initiated. Thanks!

[fivetran-joemarkiewicz]

Can you also add either another bullet here or an under the hood entry that now that model has a depends on statement and also leverages the flags.WHICH. More for our purposes so we know how this issue was addressed and some underlying impacts.

[fivetran-catfritz]

Updated!