Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bringing over changes to new branch #30

Merged
merged 30 commits into from
Jul 12, 2022

Conversation

fivetran-reneeli
Copy link
Contributor

Pull Request
Are you a current Fivetran customer?

Internal

What change(s) does this PR introduce?

We are updating the Salesforce package to improve the utility! This includes bringing additional tables to create a new Contact Enhanced and Sales Velocity model, as well as updating the Opportunity Enhanced model. Finally we are adding integration with the Salesforce Formula package by embedding the macro outputs as part of our staging models so that your custom formula fields can be included.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • [] Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • [] Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @fivetran-reneeli! It seems there are a few comments from the previous PR that were not addressed. Please make sure the following updates are applied:

  • Previous comments from the old PR about updates that need to be made to the README
  • In a similar vain, we need to add the new history and passthrough variables to our README. Please add them in the appropriate places in the README.
  • Some of the macros still have a timestamp at the top. Can we remove those.

Let me know once these updates are applied and I can re-review.

README.md Outdated Show resolved Hide resolved
macros/get_opportunity_line_item_columns.sql Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli we are so so so close to closing this out! I will approve the PR since the changes are in a great state! I only have two requested changes for this PR:

  • Super small TM addition to the dbt core badge in the README
  • When testing the passthrough columns I found my models to fail if I added a new field that existed in the macro, but not the staging model. We will want to remove any fields from the macros that are not used in the final query within the staging model.

Once those two changes are made, we will be good to go! We will still hold off merging this until the transform updates are completed.

README.md Outdated Show resolved Hide resolved
macros/get_contact_columns.sql Outdated Show resolved Hide resolved
fivetran-reneeli and others added 5 commits June 15, 2022 16:29
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-reneeli fivetran-reneeli merged commit c407fe3 into main Jul 12, 2022
@fivetran-reneeli fivetran-reneeli deleted the feature/package_updates_v2 branch July 12, 2022 15:34
@fivetran-avinash fivetran-avinash mentioned this pull request Jul 13, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants