-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/standardized billing line item model #82
Feature/standardized billing line item model #82
Conversation
packages.yml
Outdated
# version: [">=0.12.0", "<0.13.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_stripe_source.git | ||
revision: feature/standardized-billing-line-item-model | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one update! And then a docs regen so the model isn't in the manifest.
{{ config( | ||
enabled=( | ||
var('stripe__standardized_billing_model_enabled', False) and | ||
(var('stripe__using_invoices', True) and var('stripe__standardized_billing_model_enabled', True)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(var('stripe__using_invoices', True) and var('stripe__standardized_billing_model_enabled', True)) | |
(var('stripe__using_invoices', True) and var('stripe__standardized_billing_model_enabled', False)) |
This should be disabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized i never approved this!
PR Overview
This PR will address the following Issue/Feature: Internal Project
This PR will result in the following new package version:
v0.14.0
While there are no immediate breaking changes in this PR, it will include a net new end model as well as two new upstream staging models
discount
andproduct
which should be accompanied by a minor (v0.X.0) release.Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validation tests have been applied for the new end model and we are opening this feature to the community to receive feedback before broader release.
If you had to summarize this PR in an emoji, which would it be?
💬