-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuation of #88 - handle multiple disputes in stripe__balance_transactions #92
Conversation
* Documentation Standard Updates (#85) * MagicBot/documentation-updates * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com> * fix!: handle multiple disputes * replace array_agg with string_agg * update changelog * bump version --------- Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
@bramrodenburg @jsnorthrup Here's my working branch if you've got a chance to test it out! Thanks packages:
- git: https://github.com/fivetran/dbt_stripe.git
revision: releases/v0.15.latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jamie! Had some comments!
Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com>
…bt_stripe into releases/v0.15.latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie A few comments before approval
CHANGELOG.md
Outdated
@@ -1,3 +1,31 @@ | |||
# dbt_stripe v0.15.0 | |||
|
|||
## 🚨 Breaking Changes 🚨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can do emojis in Changelogs/releases anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 you're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie lgtm
PR Overview
This PR will address the following Issue/Feature:
#87
Includes merging of PR #88
This PR will result in the following new package version:
v0.15.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🚨 Breaking Changes 🚨
stripe__balance_transactions
to correctly handle multiple disputes on the same transaction:customer_facing_amount
to reflect thedispute_amount
of the latest dispute (if the transaction is not a charge or refund and is associated with any disputes).latest_dispute_amount_won
: Latest disputed amount that was won in favor of the merchant.latest_dispute_amount_lost
: Latest disputed amount that was lost and returned to the customer.latest_dispute_amount_under_review
: Latest disputed amount that is currently under review by the bank.latest_dispute_amount_needs_response
: Latest disputed amount that currently needs a response (the dispute has been filed but the merchant has not yet responded with evidence).latest_dispute_amount_warning_closed
: Latest disputed amount that is currently of statuswarning_under_closed
(early fraud warning being closed due to no formal dispute).latest_dispute_amount_warning_under_review
: Latest disputed amount that is currently of statuswarning_under_review
(card issuer suspects possible fraud but hasn't yet escalated the situation to a full dispute).latest_dispute_amount_warning_needs_response
: Latest disputed amount that is currently of statuswarning_needs_response
(early fraud warning has been escalated into formal dispute and/or card issuer has requested more information).dispute_count
: Count of disputes raised against this transaction. If > 1, join indispute
data for additional information on each dispute.dispute_id
anddispute_reason
fields to aggregate together data from multiple disputes if present. They have been renamed todispute_ids
anddispute_reasons
in the following models (PR #88):stripe__balance_transactions
stripe__activity_itemized_2
stripe__balance_change_from_activity_itemized_3
stripe__ending_balance_reconciliation_itemized_4
Under the Hood
dispute
seed data to test the above changes.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
New Validation tests passing on our internal data.
If you had to summarize this PR in an emoji, which would it be?
🥊